Fields and default layer for man_made:bridge #5269
Conversation
LaszloEr
commented
Aug 31, 2018
LaszloEr
commented
- Added name, bridge type, layer and maxweight fields
- default layer should be set to 1 (like it is for highway=bridge)
- Added name, bridge type, layer and maxweight fields - default layer should be set to 1 (like it is for highway=bridge)
|
Thanks for this PR, this is a much needed improvement. |
| "fields": [ | ||
| "name" | ||
| "bridge" | ||
| "layer" |
There was a problem hiding this comment.
Missing commas between the array values here
|
Great @LaszloEr!! Seems like some changes are required in the code. After you do the changes suggested by @SilentSpike do not forget to build the project before you push the changes. You can do it by running the command |
|
I added the missing commas, this is what it looks like: |
|
I don't think that adding a default It is easier for both data consumers and mappers to find objects without a certain tag than objects where a tag which was set by default is wrong. |
|
Good point. The reason why I wanted to add it as the default is because setting the bridge attribute on roads also adds it there automatically, probably because it's the correct for 99% of all bridges. |
|
Thanks @LaszloEr - this seems ok to me 👍 |
